fix: restore input bar padding and chat button alignment#67
fix: restore input bar padding and chat button alignment#67jeffgreendesign merged 7 commits intomainfrom
Conversation
Tailwind v4 compiles py-4 as padding-block, which overrides pb-safe's padding-bottom in the cascade. Switch to pt-4 + pb-safe and move safe-area utilities into @layer utilities. Also add sm:min-h-9 to the chat Send button to match the workspace intent-bar fix.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis pull request addresses a CSS specificity issue where Tailwind v4's 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/dashboard/chat.tsx (1)
1252-1270:⚠️ Potential issue | 🟡 MinorUpdate
voice-controls.tsxline 343 to usept-3 pb-safeinstead ofpy-3 pb-safe.The
VoiceControlscomponent usespy-3 pb-safewhich causes a Tailwind v4padding-blockcascade issue. Thepy-3class sets both padding-top and padding-bottom, thenpb-safeattempts to override only the bottom padding, resulting in inconsistent behavior. Usept-3 pb-safeto apply padding-top and safe-area-aware padding-bottom separately.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/dashboard/chat.tsx` around lines 1252 - 1270, The padding utility on the VoiceControls root needs to avoid py-3 since it sets both top and bottom and prevents pb-safe from taking effect; in the VoiceControls component (voice-controls.tsx) replace the container class that currently uses "py-3 pb-safe" with "pt-3 pb-safe" so the top padding remains and the safe-area-aware bottom padding (pb-safe) can override bottom spacing correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@app/dashboard/chat.tsx`:
- Around line 1252-1270: The padding utility on the VoiceControls root needs to
avoid py-3 since it sets both top and bottom and prevents pb-safe from taking
effect; in the VoiceControls component (voice-controls.tsx) replace the
container class that currently uses "py-3 pb-safe" with "pt-3 pb-safe" so the
top padding remains and the safe-area-aware bottom padding (pb-safe) can
override bottom spacing correctly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 88424fcb-45f5-4e63-8585-7a6247aa788f
📒 Files selected for processing (5)
CHANGELOG.mdapp/dashboard/chat.tsxapp/globals.csscomponents/dashboard/quick-actions-panel.tsxcomponents/workspace/intent-bar.tsx
1 participant
Summary
py-4aspadding-block, which overridespb-safe'spadding-bottomin the cascade. Switched topt-4 + pb-safeand moved safe-area utilities into@layer utilities.sm:min-h-9 sm:min-w-9to the chat Send button to match the workspace intent-bar fix from Add bottom padding offset to safe area inset utility #55.Test plan
npm run gatespasses